From reviews-return-92525-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 3 12:29:11 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id E42FE1AB4B for ; Thu, 3 Sep 2020 12:29:09 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 25EF9121A17 for ; Thu, 3 Sep 2020 12:29:09 +0000 (UTC) Received: (qmail 84978 invoked by uid 500); 3 Sep 2020 12:29:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 84946 invoked by uid 500); 3 Sep 2020 12:29:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84929 invoked by uid 99); 3 Sep 2020 12:29:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 12:29:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E1C301A31DE for ; Thu, 3 Sep 2020 12:29:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.613 X-Spam-Level: * X-Spam-Status: No, score=1.613 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0SNYzVJtErsL for ; Thu, 3 Sep 2020 12:29:06 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 255CBBC24E for ; Thu, 3 Sep 2020 12:29:06 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 0EAAD1603B4; Thu, 3 Sep 2020 12:29:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4979286775797298326==" MIME-Version: 1.0 Subject: Re: Review Request 72790: Deduplicated concurrent image pulls by docker store. From: Andrei Sekretenko To: Qian Zhang Cc: Andrei Sekretenko , mesos Date: Thu, 03 Sep 2020 12:29:04 -0000 Message-ID: <20200903122904.13941.55424@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72790/ X-Sender: Andrei Sekretenko References: <20200820170619.26190.2440@reviews-vm-he-fi.apache.org> In-Reply-To: <20200820170619.26190.2440@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============4979286775797298326== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72790/ ----------------------------------------------------------- (Updated Sept. 3, 2020, 12:29 p.m.) Review request for mesos and Qian Zhang. Changes ------- Added a comment for the pull hashmap; fixed indentation. Bugs: MESOS-10169 https://issues.apache.org/jira/browse/MESOS-10169 Repository: mesos Description ------- This patch makes the docker store reuse a pending pull if asked for an image that is already being pulled. The pull caching follows the same approach as the earlier attempt in https://reviews.apache.org/r/39331 . However, handing out futures to the store callers and handling their discards are performed differently, using a form of reference counting, so that the pull itself is discarded only if all the futures returned by `Store::get()` have been discarded. Diffs (updated) ----- src/slave/containerizer/mesos/provisioner/docker/store.cpp bf2be90aa4fcd7541849a157eb6930b491ccf03a Diff: https://reviews.apache.org/r/72790/diff/2/ Changes: https://reviews.apache.org/r/72790/diff/1-2/ Testing ------- Thanks, Andrei Sekretenko --===============4979286775797298326==--