From reviews-return-92524-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 3 11:15:08 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 8A9951A848 for ; Thu, 3 Sep 2020 11:15:08 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 3A8C21217E2 for ; Thu, 3 Sep 2020 11:15:08 +0000 (UTC) Received: (qmail 33465 invoked by uid 500); 3 Sep 2020 11:15:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33437 invoked by uid 500); 3 Sep 2020 11:15:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33409 invoked by uid 99); 3 Sep 2020 11:15:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 11:15:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B98D71A42B3 for ; Thu, 3 Sep 2020 11:15:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.613 X-Spam-Level: * X-Spam-Status: No, score=1.613 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8qKJTfsOSa07 for ; Thu, 3 Sep 2020 11:15:05 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id E5BA9BC291 for ; Thu, 3 Sep 2020 11:15:04 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 8F1C01603B4; Thu, 3 Sep 2020 11:15:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0993190248881774090==" MIME-Version: 1.0 Subject: Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Thu, 03 Sep 2020 11:15:03 -0000 Message-ID: <20200903111503.2546.21157@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72824/ X-Sender: Andrei Sekretenko References: <20200902180251.2546.30162@reviews-vm-he-fi.apache.org> In-Reply-To: <20200902180251.2546.30162@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============0993190248881774090== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 2, 2020, 6:02 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 2847-2848 (patched) > > > > > > No pid change possible in this path? (unlike the other TODO below?) If so, perhaps state so expicitly? Good catch! The HTTP `subscribe()` can remove the PID in case of a framework upgrade from V0 to HTTP. I have to adjust the comment. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72824/#review221784 ----------------------------------------------------------- On Sept. 2, 2020, 2:08 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72824/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2020, 2:08 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10166 > https://issues.apache.org/jira/browse/MESOS-10166 > > > Repository: mesos > > > Description > ------- > > This patch makes the UPDATE_FRAMEWORK call avoid sending the > `UpdatedFrameworkMessage` to agents and the `FRAMEWORK_UPDATED` > event to V1 API subscribers when the FrameworkInfo is not changed > by the call. > > > Diffs > ----- > > src/master/master.cpp 02723296e569fac9d553b1494a5ca7daa6ef9aa4 > > > Diff: https://reviews.apache.org/r/72824/diff/4/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============0993190248881774090==--