From reviews-return-92521-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 3 07:30:40 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id ACBC91A02A for ; Thu, 3 Sep 2020 07:30:40 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 5DE7212178A for ; Thu, 3 Sep 2020 07:30:40 +0000 (UTC) Received: (qmail 58340 invoked by uid 500); 3 Sep 2020 07:30:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 58312 invoked by uid 500); 3 Sep 2020 07:30:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 58295 invoked by uid 99); 3 Sep 2020 07:30:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 07:30:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1C1D8C0BC1 for ; Thu, 3 Sep 2020 07:30:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.313 X-Spam-Level: **** X-Spam-Status: No, score=4.313 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_NONE=0.25, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, NML_ADSP_CUSTOM_MED=1.2, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LgKAJ0zq9XEb for ; Thu, 3 Sep 2020 07:30:38 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 9AF1FBC27B for ; Thu, 3 Sep 2020 07:30:37 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 0612F1603B4; Thu, 3 Sep 2020 07:30:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1873739378489002776==" MIME-Version: 1.0 Subject: Re: Review Request 72794: Added a test for discarding image pull on discard of getting image. From: Qian Zhang To: Qian Zhang Cc: Andrei Sekretenko , mesos Date: Thu, 03 Sep 2020 07:30:35 -0000 Message-ID: <20200903073035.13941.45345@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72794/ X-Sender: Qian Zhang X-ReviewBoard-ShipIt: 1 References: <20200820170810.26190.82066@reviews-vm-he-fi.apache.org> In-Reply-To: <20200820170810.26190.82066@reviews-vm-he-fi.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============1873739378489002776== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72794/#review221792 ----------------------------------------------------------- Fix it, then Ship it! Ship It! src/tests/containerizer/provisioner_docker_tests.cpp Lines 437-438 (patched) A newline between. - Qian Zhang On Aug. 21, 2020, 1:08 a.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72794/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2020, 1:08 a.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10169 > https://issues.apache.org/jira/browse/MESOS-10169 > > > Repository: mesos > > > Description > ------- > > This test checks that when all futures returned by docker store's > `get()` that are pending image pull are discarded by the callers, > the pull future (returned by the puller to the store) is discarded > by the store as well. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc > > > Diff: https://reviews.apache.org/r/72794/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============1873739378489002776==--