From reviews-return-92504-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 2 13:35:48 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by minotaur.apache.org (Postfix) with ESMTP id AC69319755 for ; Wed, 2 Sep 2020 13:35:47 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 5E1CC453DE for ; Wed, 2 Sep 2020 13:35:47 +0000 (UTC) Received: (qmail 33988 invoked by uid 500); 2 Sep 2020 13:35:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33975 invoked by uid 500); 2 Sep 2020 13:35:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33958 invoked by uid 99); 2 Sep 2020 13:35:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Sep 2020 13:35:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 08AEB181449 for ; Wed, 2 Sep 2020 13:35:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.564 X-Spam-Level: **** X-Spam-Status: No, score=4.564 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_NONE=0.25, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.399, NML_ADSP_CUSTOM_MED=1.2, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id a05WwlVWb8EC for ; Wed, 2 Sep 2020 13:35:41 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id D5883BC30A for ; Wed, 2 Sep 2020 13:35:40 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id E89001603B4; Wed, 2 Sep 2020 13:35:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6270614528083132542==" MIME-Version: 1.0 Subject: Re: Review Request 72728: Added tests for the 'volume/csi' isolator. From: Qian Zhang To: Qian Zhang , Andrei Budnik Cc: Greg Mann , mesos Date: Wed, 02 Sep 2020 13:35:39 -0000 Message-ID: <20200902133539.13941.93500@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72728/ X-Sender: Qian Zhang References: <20200902055741.13989.70045@reviews-vm-he-fi.apache.org> In-Reply-To: <20200902055741.13989.70045@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/volume_csi_isolator_tests.cpp Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============6270614528083132542== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221754 ----------------------------------------------------------- src/Makefile.am Lines 2875 (patched) The indent seems not correct. src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 21-22 (patched) I think we should swap these two lines and add a newline between them. src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 95 (patched) This one seems unused. src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 132-133 (patched) A newline between, or we could just swap these two lines. src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 238 (patched) Do we really need this method? I see it is only called when we create CSI server in `ROOT_PluginConfigAddedAtRuntime`, can we just create the CSI server with NULL secret generator like what we do in `ROOT_InvalidPluginConfig`? src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 794 (patched) Usually we use `SUDO_USER` as the non-root user in our unit tests, see https://github.com/apache/mesos/blob/1.10.0/src/tests/containerizer/docker_volume_isolator_tests.cpp#L1335 . And the test name should have the `UNPRIVILEGED_USER_` prefix. Just realized in a couple of your tests here, we need to pull Docker image `alpine` from Docker Hub, right? Then I think we need to include the prefix `INTERNET_CURL_` in the test name. - Qian Zhang On Sept. 2, 2020, 1:57 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72728/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2020, 1:57 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > Added tests for the 'volume/csi' isolator. > > > Diffs > ----- > > src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63 > src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226 > src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370 > src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72728/diff/13/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` > > > Thanks, > > Greg Mann > > --===============6270614528083132542==--