From reviews-return-92494-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Sep 1 19:50:51 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by minotaur.apache.org (Postfix) with ESMTP id BD85D195AB for ; Tue, 1 Sep 2020 19:50:50 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 7DEEA453DE for ; Tue, 1 Sep 2020 19:50:50 +0000 (UTC) Received: (qmail 61555 invoked by uid 500); 1 Sep 2020 19:50:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 61497 invoked by uid 500); 1 Sep 2020 19:50:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61430 invoked by uid 99); 1 Sep 2020 19:50:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2020 19:50:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1D376C121D for ; Tue, 1 Sep 2020 19:50:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.611 X-Spam-Level: * X-Spam-Status: No, score=1.611 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OdRs4CXcGCV0 for ; Tue, 1 Sep 2020 19:50:47 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 735727F980 for ; Tue, 1 Sep 2020 19:50:47 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id D6EE91603B5; Tue, 1 Sep 2020 19:50:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2673485914391924755==" MIME-Version: 1.0 Subject: Review Request 72832: Avoided unnecessary [] map operators in the master. From: Benjamin Mahler To: Greg Mann Cc: Benjamin Mahler , mesos Date: Tue, 01 Sep 2020 19:50:46 -0000 Message-ID: <20200901195046.2546.6590@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72832/ X-Sender: Benjamin Mahler Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============2673485914391924755== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72832/ ----------------------------------------------------------- Review request for mesos and Greg Mann. Repository: mesos Description ------- To avoid the potential for accidental insertion into the maps, we prefer to use the .at operator for const access. Diffs ----- src/master/master.cpp 02723296e569fac9d553b1494a5ca7daa6ef9aa4 Diff: https://reviews.apache.org/r/72832/diff/1/ Testing ------- make check Thanks, Benjamin Mahler --===============2673485914391924755==--