----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72822/ ----------------------------------------------------------- (Updated Sept. 1, 2020, 7:45 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Moved from `protobuf_utils` into `type_utils`/`v1/mesos.hpp`. Bugs: MESOS-10166 https://issues.apache.org/jira/browse/MESOS-10166 Repository: mesos Description ------- This patch extracts the code that performs `FrameworkInfo` comparison via protobuf `MessageDifferencer` from the framework update tests into a set of general-purpose methods. Diffs (updated) ----- include/mesos/type_utils.hpp da9fd9694b08827b968514b4b078097c912640c8 include/mesos/v1/mesos.hpp d8304f10d6ac6bbcf014e515e0bfd77a2b96e138 src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63 src/common/type_utils.cpp bb437844183688e7f69eb0874d87efe5a7d6daf2 src/common/type_utils_impl.hpp PRE-CREATION src/tests/master/update_framework_tests.cpp d2a63b696e976d9e3c729390d80f33180ab4aa1c src/v1/mesos.cpp c2fb528d323899c42b32c0713b38ebf6f909dd29 Diff: https://reviews.apache.org/r/72822/diff/3/ Changes: https://reviews.apache.org/r/72822/diff/2-3/ Testing ------- Thanks, Andrei Sekretenko