From reviews-return-92485-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Sep 1 15:35:00 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 6D230196CB for ; Tue, 1 Sep 2020 15:35:00 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 1473C123A8D for ; Tue, 1 Sep 2020 15:35:00 +0000 (UTC) Received: (qmail 30266 invoked by uid 500); 1 Sep 2020 15:34:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 30249 invoked by uid 500); 1 Sep 2020 15:34:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 30229 invoked by uid 99); 1 Sep 2020 15:34:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2020 15:34:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AA1E8C018C for ; Tue, 1 Sep 2020 15:34:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MMoSAkUlCnyB for ; Tue, 1 Sep 2020 15:34:56 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 37FF47F977 for ; Tue, 1 Sep 2020 15:34:56 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 9B0A61603B3; Tue, 1 Sep 2020 15:34:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3652230765842791466==" MIME-Version: 1.0 Subject: Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. From: Mesos Reviewbot To: Qian Zhang Cc: Mesos Reviewbot , Greg Mann , mesos Date: Tue, 01 Sep 2020 15:34:55 -0000 Message-ID: <20200901153455.2546.12539@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72806/ X-Sender: Mesos Reviewbot References: <20200829004803.26190.84939@reviews-vm-he-fi.apache.org> In-Reply-To: <20200829004803.26190.84939@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/volume_csi_isolator_tests.cpp Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============3652230765842791466== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72806/#review221765 ----------------------------------------------------------- Patch looks great! Reviews applied: [72816, 72727, 72805, 72728, 72806] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 29, 2020, 12:48 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72806/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2020, 12:48 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added a test for 'volume/csi' isolator recovery. > > > Diffs > ----- > > src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72806/diff/2/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*UnpublishAfterAgentFailover*"` > > > Thanks, > > Greg Mann > > --===============3652230765842791466==--