From reviews-return-92580-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 10 16:58:54 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 7D4C619D81 for ; Thu, 10 Sep 2020 16:58:54 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 26600122EC5 for ; Thu, 10 Sep 2020 16:58:54 +0000 (UTC) Received: (qmail 26776 invoked by uid 500); 10 Sep 2020 15:58:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 26764 invoked by uid 500); 10 Sep 2020 15:58:54 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26747 invoked by uid 99); 10 Sep 2020 15:58:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Sep 2020 15:58:54 +0000 From: =?utf-8?q?GitBox?= To: reviews@mesos.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmesos=5D_asekretenko_commented_on_a_change_in_pull?= =?utf-8?q?_request_=23367=3A_Expose_hierarchical_allocator_recovery_paramet?= =?utf-8?q?ers_as_master_flags?= Message-ID: <159975353446.32230.12165611842045183294.asfpy@gitbox.apache.org> Date: Thu, 10 Sep 2020 15:58:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: asekretenko commented on a change in pull request #367: URL: https://github.com/apache/mesos/pull/367#discussion_r486441078 ########## File path: src/master/flags.cpp ########## @@ -460,6 +460,18 @@ mesos::internal::master::Flags::Flags() "load an alternate allocator module using `--modules`.", DEFAULT_ALLOCATOR); + add(&Flags::hierarchical_recovery_factor, + "hierarchical_recovery_factor", Review comment: `allocator_agent_recovery_factor`? (see my comment on the word "hierarchical" below) ########## File path: src/master/allocator/mesos/hierarchical.hpp ########## @@ -755,6 +755,8 @@ class HierarchicalAllocatorProcess : public MesosAllocatorProcess // Recovery data. Option expectedAgentCount; + float agentRecoveryFactor; Review comment: Is it possible to just use these values from `options`? Why keep a copy? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org