mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Date Fri, 25 Sep 2020 20:26:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72448/#review221963
-----------------------------------------------------------




src/common/http.hpp
Lines 402-404 (original), 401-403 (patched)
<https://reviews.apache.org/r/72448/#comment311028>

    The comment about MESOS-10085 is not relevant anymore after this patch?



src/common/http.hpp
Lines 419 (patched)
<https://reviews.apache.org/r/72448/#comment311030>

    Does this correctly handle `tryApproved<VIEW_ROLE>(...)`?
    
    If no, then can you make sure (at the very least, with a `static_assert`) that it is not
accidentally used for VIEW_ROLE?



src/common/http.hpp
Lines 422-426 (patched)
<https://reviews.apache.org/r/72448/#comment311029>

    Just `return approved(...)` ?



src/master/master.cpp
Line 12277 (original), 12286 (patched)
<https://reviews.apache.org/r/72448/#comment311032>

    Can you follow the same approach for obtaining `VIEW_ROLE` authorization as well, here
and below?


- Andrei Sekretenko


On July 23, 2020, 11:03 a.m., Dong Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72448/
> -----------------------------------------------------------
> 
> (Updated July 23, 2020, 11:03 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch intends to fix issue MESOS-10085.
> 
> When the authorization failed happens master return nothing to the
> subscriber, subscriber isn't aware of what is happening, this issue
> can lead to inconsistencies in Event stream.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 021dadcea026da41347b3aaee5ddd12f4f14fa29 
>   include/mesos/v1/master/master.proto 488fe294e8bfe8e0c6fc23c88f06c0d41169b96d 
>   src/common/http.hpp 02633e175c0848ee622cb5108a2e18db5e030641 
>   src/master/master.cpp a8cca622ff0bd172300b9a2717b4860ed06b620c 
>   src/tests/master/mock_master_api_subscriber.cpp 893d3e366164ccebd2847ed4c2874ab00e0e5b7b

> 
> 
> Diff: https://reviews.apache.org/r/72448/diff/3/
> 
> 
> Testing
> -------
> 
> - Manually tested
>   - make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message