mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Date Fri, 25 Sep 2020 15:48:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72900/
-----------------------------------------------------------

(Updated Sept. 25, 2020, 5:48 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

- Fixed the signature comment in the C++ JNI code
 - `updateFramework` javadoc comments: synced from the C++ driver, adjusted @params, added
@deprecated to the comment for the old signature.


Bugs: MESOS-10189
    https://issues.apache.org/jira/browse/MESOS-10189


Repository: mesos


Description
-------

Added offer constraints to `updateFramework()` in the Java bindings.


Diffs (updated)
-----

  src/examples/java/TestFramework.java 1dea79c0e5b76385bad74ded755911f4d1858112 
  src/java/jni/construct.cpp a48ca07664f7178df97c3a9557f6908507442333 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 1817bbafc4ce65ee5e58eb787e71c6d06481a32f

  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3e74be9e59e1419569ad940e5db5390b629ca376

  src/java/src/org/apache/mesos/SchedulerDriver.java e04916e055349ee287eb0c9327bc5f6d1e6caec3



Diff: https://reviews.apache.org/r/72900/diff/2/

Changes: https://reviews.apache.org/r/72900/diff/1-2/


Testing
-------

Testing Done

With empty constraints:
make check
(and, specifically, src/mesos-tests --gtest_filter='ExamplesTest.JavaFramework')


With non-empty constraints: extended ExamplesTest.JavaFramework (see WIP https://reviews.apache.org/r/72901
which will most likely be discarded) and re-ran it.


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message