-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72900/#review221954
-----------------------------------------------------------
Fix it, then Ship it!
src/examples/java/TestFramework.java
Lines 31-53 (original), 31-58 (patched)
<https://reviews.apache.org/r/72900/#comment311021>
Seems we should separate the TestFramework.java changes from the binding changes?
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp
Line 1071 (original), 1071 (patched)
<https://reviews.apache.org/r/72900/#comment311022>
The suppressed roles collection is gone now? (Not sure if it was specified right originally)
- Benjamin Mahler
On Sept. 22, 2020, 6:09 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72900/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2020, 6:09 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10189
> https://issues.apache.org/jira/browse/MESOS-10189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added offer constraints to `updateFramework()` in the Java bindings.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java 1dea79c0e5b76385bad74ded755911f4d1858112
> src/java/jni/construct.cpp 8d8f76e4602e506faa635970f096d344a9ad8562
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 1817bbafc4ce65ee5e58eb787e71c6d06481a32f
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3e74be9e59e1419569ad940e5db5390b629ca376
> src/java/src/org/apache/mesos/SchedulerDriver.java e04916e055349ee287eb0c9327bc5f6d1e6caec3
>
>
> Diff: https://reviews.apache.org/r/72900/diff/1/
>
>
> Testing
> -------
>
> Testing Done
>
> With empty constraints:
> make check
> (and, specifically, src/mesos-tests --gtest_filter='ExamplesTest.JavaFramework')
>
>
> With non-empty constraints: extended ExamplesTest.JavaFramework (see WIP https://reviews.apache.org/r/72901
which will most likely be discarded) and re-ran it.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
|