mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
Date Thu, 24 Sep 2020 18:16:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72874/#review221953
-----------------------------------------------------------


Ship it!





include/mesos/scheduler.hpp
Lines 364-365 (original), 367-369 (patched)
<https://reviews.apache.org/r/72874/#comment311020>

    Note that this is the first rvalue reference in the driver interface. Which is largely
because we weren't yet on C++11 when most of this interface was written.


- Benjamin Mahler


On Sept. 22, 2020, 5:57 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72874/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2020, 5:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10189
>     https://issues.apache.org/jira/browse/MESOS-10189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an ability to set V0 framework's offer constraints
> via the C++ V0 scheduler driver.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp 61cc846a03d2980f18fa66df1de196edc5cb4457 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 1817bbafc4ce65ee5e58eb787e71c6d06481a32f

>   src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 256632a9589c8573cbe0f0aeb39ee6cb1e4b3256

>   src/sched/sched.cpp 768ce7d4074a1ea50b656717e25be6c38a423368 
>   src/tests/master/update_framework_tests.cpp d6c45f60cf50739aacbb507e99a5163a6cb3d1a0

>   src/tests/scheduler_driver_tests.cpp 63d7a3ba9a98d8c343324f5ad85f0b4d0cc033be 
> 
> 
> Diff: https://reviews.apache.org/r/72874/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message