-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72899/#review221951
-----------------------------------------------------------
Ship it!
src/tests/master/offer_constraints_filter_tests.cpp
Lines 586 (patched)
<https://reviews.apache.org/r/72899/#comment311018>
Not sure this sentence adds anything on top of the test name. Maybe:
Tests that an empty OfferConstraints includes all agents?
- Benjamin Mahler
On Sept. 24, 2020, 3:06 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72899/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2020, 3:06 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10189
> https://issues.apache.org/jira/browse/MESOS-10189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for creating a filter from default `OfferConstraints`.
>
>
> Diffs
> -----
>
> src/tests/master/offer_constraints_filter_tests.cpp f80d56c89d937b6a1b261202adefb37a1519bf0d
>
>
> Diff: https://reviews.apache.org/r/72899/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
|