mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Review Request 72897: Allowed `OfferConstraintsFilter::create()` to return an empty `Result`.
Date Tue, 22 Sep 2020 18:05:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72897/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10189
    https://issues.apache.org/jira/browse/MESOS-10189


Repository: mesos


Description
-------

This patch makes it possible for the offer constraint filter creation
to return `None()` in cases when specified offer constraints would
result in creating a no-op `OfferConstraintsFilter` that would never
filter out anything, and actually implements this special handling
for an `OfferConstraints` message with an empty role constraints map.


Diffs
-----

  include/mesos/allocator/allocator.hpp 6d67d5d5c32c1f18cdf6f925d747156c2bbc7820 
  src/master/allocator/mesos/offer_constraints_filter.cpp 441ebc10219bf3bd623fac2bb08945ea9deb7ea3

  src/master/master.cpp fefa72d338384b6ccb1bcbbed7192713411035db 
  src/tests/master/offer_constraints_filter_tests.cpp f80d56c89d937b6a1b261202adefb37a1519bf0d



Diff: https://reviews.apache.org/r/72897/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message