-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72887/#review221919
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.hpp
Line 976 (original), 978-979 (patched)
<https://reviews.apache.org/r/72887/#comment310970>
Don't need to move this if we want to minimize the diff?
- Benjamin Mahler
On Sept. 21, 2020, 12:43 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72887/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2020, 12:43 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The instances of `HierarchicalAllocatorProcess` launched in the same
> instance of libprocess after that will be assigned IDs like
> "allocator(2)", "allocator(3)" and so on.
>
> This allows the user to specify a fixed URL like
> `https://localhost:5050/allocator/offer_constraints_debug` when querying
> HTTP endpoints of an allocator in the mesos-master program instead of
> looking up the allocator UPID and using that to compose an URL (like
> `https://localhost:5050/hierarchical_allocator(1)/...`)
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 225de160772fe689e07877c895800eb711f211b5
>
>
> Diff: https://reviews.apache.org/r/72887/diff/2/
>
>
> Testing
> -------
>
> `make check` on several platforms + tested the debug endpoint manually
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
|