mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72888: Inferred CSI volume's `readonly` field from volume mode.
Date Sat, 19 Sep 2020 10:56:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72888/#review221902
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72888]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Sept. 19, 2020, 1:05 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72888/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2020, 1:05 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10153
>     https://issues.apache.org/jira/browse/MESOS-10153
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Inferred CSI volume's `readonly` field from volume mode.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a10084439d5f86855ce179e7a2eba1a46b15c948 
>   include/mesos/v1/mesos.proto 09973abb94ef016c1fca4055ea781b21be5cb4fb 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp 4349acd93687f2a218ed6bf0b09e0cbc63c10822

>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 79a68606ab1f1a2dc5c68acf4f50bdfec44ff4ec

>   src/slave/csi_server.hpp de5c6b6a859b4f5cb0db18636196850b660e17bf 
>   src/slave/csi_server.cpp 14fa8664e4d0a6645510babcbe4c8cfa69bb4c96 
>   src/tests/containerizer/volume_csi_isolator_tests.cpp d51d3c94e1a707f54d6b36ce6484068243e696c2

>   src/tests/mesos.hpp 49abfc2aabaa151f9b7642db2ba34bf63554d48e 
> 
> 
> Diff: https://reviews.apache.org/r/72888/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message