mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Date Fri, 18 Sep 2020 19:52:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72851/#review221896
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 3246 (patched)
<https://reviews.apache.org/r/72851/#comment310954>

    excluded_by_attribute_constraints is what the code is doing?
    
    I was going to ask what the strategy for more constraints was, but I guess with the attribute
constraint we can addd other exclusion keys for resource constraints etc



src/master/allocator/mesos/hierarchical.cpp
Lines 3247 (patched)
<https://reviews.apache.org/r/72851/#comment310953>

    How about s/foo/role1/ and s/bar/role2/



src/master/allocator/mesos/hierarchical.cpp
Lines 3309-3311 (patched)
<https://reviews.apache.org/r/72851/#comment310955>

    Looks good: easy to tell in the json which ones don't have constraints set.


- Benjamin Mahler


On Sept. 18, 2020, 4:56 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72851/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2020, 4:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10177
>     https://issues.apache.org/jira/browse/MESOS-10177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an endpoint for debugging offer constraints.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp c6fca65b5b886dec26807871b750c6a9587faee0 
>   src/master/allocator/mesos/hierarchical.hpp 7e1980ef74bb4138b83707de7698f1993cc21e41

>   src/master/allocator/mesos/hierarchical.cpp 47f8a2bfa267d68d39d2c255c7c97c8f213d5f69

>   src/master/master.cpp 54b24b4eb8824737b10b3b4d6d51f387360570a1 
> 
> 
> Diff: https://reviews.apache.org/r/72851/diff/3/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message