mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Date Tue, 08 Sep 2020 17:09:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72843/#review221817
-----------------------------------------------------------


Ship it!





src/master/http.cpp
Lines 2368-2370 (original), 2368-2370 (patched)
<https://reviews.apache.org/r/72843/#comment310904>

    A bit hard for me to understand how the comment relates to the code, I guess what I should
be getting out of this comment is that the object approvers are always functionally equivalent
now?
    
    Seems like the comment belongs up above in the de-duplication search?
    
    ```
            // NOTE: This is not a general-purpose request comparison, but
            // specific to the batched requests which are always members of
            // `ReadOnlyHandler`, since we rely on the response only depending
            // on query parameters and the current master state.
            // 
            // We don't need to check that the ObjectApprovers are the same,
            // since ...?
            return handler == batchedRequest.handler &&
                   principal == batchedRequest.principal &&
                   outputContentType == batchedRequest.outputContentType &&
                   queryParameters == batchedRequest.queryParameters;
    ```
    
    Down here it seems like there's nothing related to object approvers to comment on.


- Benjamin Mahler


On Sept. 8, 2020, 2:57 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72843/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2020, 2:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that synchronous authorization requires the authorizer to keep
> object approvers up-to-date by the authorizer, batched processing
> of readonly requests in the Master no longer intorduces an additional
> delay into propagation of permission changes.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp f34ea54ec48065f526327252aa10c6d917a96601 
> 
> 
> Diff: https://reviews.apache.org/r/72843/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message