mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`.
Date Thu, 03 Sep 2020 15:34:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72833/
-----------------------------------------------------------

(Updated Sept. 3, 2020, 5:34 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

- marked `operator==` as `= delete`;
 - got rid of `addFramework` call matching in the `MasterAllocatorTest.OutOfOrderDispatch`
test


Bugs: MESOS-10166
    https://issues.apache.org/jira/browse/MESOS-10166


Repository: mesos


Description
-------

This patch removes the outdated `operator==` for `FrameworkInfo`
(which has been comparing only `name` and `user` fields)
and replaces it with `equivalent()` in the tests that need to compare
`FrameworkInfo`s.


Diffs (updated)
-----

  include/mesos/type_utils.hpp da9fd9694b08827b968514b4b078097c912640c8 
  include/mesos/v1/mesos.hpp d8304f10d6ac6bbcf014e515e0bfd77a2b96e138 
  src/tests/api_tests.cpp e0ce0335bf99f1f624efcca8c86f797df472d68f 
  src/tests/master_allocator_tests.cpp 416b7ba733c3a9fc75e64fecf088ff13548bab3f 
  src/tests/resources_tests.cpp bd044310e297174155b88d5694641acd5df4cf59 


Diff: https://reviews.apache.org/r/72833/diff/2/

Changes: https://reviews.apache.org/r/72833/diff/1-2/


Testing
-------

`support/mesos-gtest-runner.py src/mesos-tests`


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message