mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Date Thu, 03 Sep 2020 15:29:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72822/
-----------------------------------------------------------

(Updated Sept. 3, 2020, 5:29 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

- converted `FrameworkInfoDifferencer` into a function
- renamed the header


Bugs: MESOS-10166
    https://issues.apache.org/jira/browse/MESOS-10166


Repository: mesos


Description
-------

This patch extracts the code that performs `FrameworkInfo` comparison
via protobuf `MessageDifferencer` from the framework update tests
into a set of general-purpose methods.


Diffs (updated)
-----

  include/mesos/type_utils.hpp da9fd9694b08827b968514b4b078097c912640c8 
  include/mesos/v1/mesos.hpp d8304f10d6ac6bbcf014e515e0bfd77a2b96e138 
  src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63 
  src/common/type_utils.cpp bb437844183688e7f69eb0874d87efe5a7d6daf2 
  src/common/type_utils_differencers.hpp PRE-CREATION 
  src/tests/master/update_framework_tests.cpp d2a63b696e976d9e3c729390d80f33180ab4aa1c 
  src/v1/mesos.cpp c2fb528d323899c42b32c0713b38ebf6f909dd29 


Diff: https://reviews.apache.org/r/72822/diff/4/

Changes: https://reviews.apache.org/r/72822/diff/3-4/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message