mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Date Thu, 03 Sep 2020 11:15:03 GMT


> On Sept. 2, 2020, 6:02 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Lines 2847-2848 (patched)
> > <https://reviews.apache.org/r/72824/diff/4/?file=2239176#file2239176line2847>
> >
> >     No pid change possible in this path? (unlike the other TODO below?) If so, perhaps
state so expicitly?

Good catch!
The HTTP `subscribe()` can remove the PID in case of a framework upgrade from V0 to HTTP.
I have to adjust the comment.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72824/#review221784
-----------------------------------------------------------


On Sept. 2, 2020, 2:08 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72824/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2020, 2:08 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10166
>     https://issues.apache.org/jira/browse/MESOS-10166
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the UPDATE_FRAMEWORK call avoid sending the
> `UpdatedFrameworkMessage` to agents and the `FRAMEWORK_UPDATED`
> event to V1 API subscribers when the FrameworkInfo is not changed
> by the call.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 02723296e569fac9d553b1494a5ca7daa6ef9aa4 
> 
> 
> Diff: https://reviews.apache.org/r/72824/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message