mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Date Wed, 02 Sep 2020 18:02:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72824/#review221784
-----------------------------------------------------------


Ship it!





src/master/master.cpp
Lines 2847-2848 (patched)
<https://reviews.apache.org/r/72824/#comment310850>

    No pid change possible in this path? (unlike the other TODO below?) If so, perhaps state
so expicitly?



src/master/master.cpp
Lines 2856 (patched)
<https://reviews.apache.org/r/72824/#comment310851>

    Removing both "a " occurrences from this line would be more consistent with our existing
logging
    
    Also, if we have the Framework in hand, we can just do: `<< framework` which will
include the ID and name (and possibly PID)



src/master/master.cpp
Lines 2858 (patched)
<https://reviews.apache.org/r/72824/#comment310852>

    No need for the backticks here, I think we just use them for comments and try to avoid
them in logging (but some have slipped in)



src/master/master.cpp
Lines 2858-2860 (original), 2865-2866 (patched)
<https://reviews.apache.org/r/72824/#comment310853>

    Probably this doesn't need to be touched in this patch?



src/master/master.cpp
Lines 3310-3314 (patched)
<https://reviews.apache.org/r/72824/#comment310854>

    Thanks!


- Benjamin Mahler


On Sept. 2, 2020, 2:08 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72824/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2020, 2:08 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10166
>     https://issues.apache.org/jira/browse/MESOS-10166
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the UPDATE_FRAMEWORK call avoid sending the
> `UpdatedFrameworkMessage` to agents and the `FRAMEWORK_UPDATED`
> event to V1 API subscribers when the FrameworkInfo is not changed
> by the call.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 02723296e569fac9d553b1494a5ca7daa6ef9aa4 
> 
> 
> Diff: https://reviews.apache.org/r/72824/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message