mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72832: Avoided unnecessary [] map operators in the master.
Date Tue, 01 Sep 2020 23:16:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72832/#review221773
-----------------------------------------------------------



Bad review!

Reviews applied: [72832, 72830, 72831]

Error:
Circular dependency detected for review 72830.Please fix the 'depends_on' field.

- Mesos Reviewbot


On Sept. 1, 2020, 7:50 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72832/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2020, 7:50 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To avoid the potential for accidental insertion into the maps,
> we prefer to use the .at operator for const access.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 02723296e569fac9d553b1494a5ca7daa6ef9aa4 
> 
> 
> Diff: https://reviews.apache.org/r/72832/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message