mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir.
Date Tue, 01 Sep 2020 13:30:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72829/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10153
    https://issues.apache.org/jira/browse/MESOS-10153


Repository: mesos


Description
-------

The `volume/csi` isolator needs to checkpoint CSI volume state under
work dir rather than runtime dir to be consistent with what volume
manager does. Otherwise after agent host is rebooted, volume manager
may publish some volumes during recovery, and those volumes will never
get chance to be unpublished since the `volume/csi` isolator does not
know those volumes at all (the contents in runtime dir will be gone
after reboot).


Diffs
-----

  src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp d5d8835f00798884bcf46f728470ee18868b405c

  src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp 5b4a4eeed0e85a5bed90056638414acf3a9e7ab5



Diff: https://reviews.apache.org/r/72829/diff/1/


Testing
-------


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message