mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] Lqp1 commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
Date Sat, 12 Sep 2020 22:04:10 GMT

Lqp1 commented on a change in pull request #367:
URL: https://github.com/apache/mesos/pull/367#discussion_r486892113



##########
File path: src/master/flags.cpp
##########
@@ -460,6 +460,18 @@ mesos::internal::master::Flags::Flags()
       "load an alternate allocator module using `--modules`.",
       DEFAULT_ALLOCATOR);
 
+  add(&Flags::hierarchical_recovery_factor,
+      "hierarchical_recovery_factor",
+      "Ratio of minimal re-registred agent before sending\n"

Review comment:
       You're right; I used your sentence it seems fine to me too.

##########
File path: src/master/allocator/mesos/hierarchical.hpp
##########
@@ -755,6 +755,8 @@ class HierarchicalAllocatorProcess : public MesosAllocatorProcess
 
   // Recovery data.
   Option<int> expectedAgentCount;
+  float agentRecoveryFactor;

Review comment:
       My bad I reworked my patch and forgot to clean this.

##########
File path: include/mesos/allocator/allocator.hpp
##########
@@ -28,6 +28,8 @@
 
 #include <mesos/quota/quota.hpp>
 
+#include <master/constants.hpp>

Review comment:
       So the flags defined for master will depend on `include/allocator/allocator.hpp` header
(instead of the more generic `constants.hpp`? Is that ok?

##########
File path: src/master/flags.cpp
##########
@@ -460,6 +460,18 @@ mesos::internal::master::Flags::Flags()
       "load an alternate allocator module using `--modules`.",
       DEFAULT_ALLOCATOR);
 
+  add(&Flags::hierarchical_recovery_factor,
+      "hierarchical_recovery_factor",
+      "Ratio of minimal re-registred agent before sending\n"

Review comment:
       You're right; I used your sentence it seems fine to me too.

##########
File path: src/master/allocator/mesos/hierarchical.hpp
##########
@@ -755,6 +755,8 @@ class HierarchicalAllocatorProcess : public MesosAllocatorProcess
 
   // Recovery data.
   Option<int> expectedAgentCount;
+  float agentRecoveryFactor;

Review comment:
       My bad I reworked my patch and forgot to clean this.

##########
File path: include/mesos/allocator/allocator.hpp
##########
@@ -28,6 +28,8 @@
 
 #include <mesos/quota/quota.hpp>
 
+#include <master/constants.hpp>

Review comment:
       So the flags defined for master will depend on `include/allocator/allocator.hpp` header
(instead of the more generic `constants.hpp`? Is that ok?

##########
File path: src/master/flags.cpp
##########
@@ -460,6 +460,18 @@ mesos::internal::master::Flags::Flags()
       "load an alternate allocator module using `--modules`.",
       DEFAULT_ALLOCATOR);
 
+  add(&Flags::hierarchical_recovery_factor,
+      "hierarchical_recovery_factor",
+      "Ratio of minimal re-registred agent before sending\n"

Review comment:
       You're right; I used your sentence it seems fine to me too.

##########
File path: src/master/allocator/mesos/hierarchical.hpp
##########
@@ -755,6 +755,8 @@ class HierarchicalAllocatorProcess : public MesosAllocatorProcess
 
   // Recovery data.
   Option<int> expectedAgentCount;
+  float agentRecoveryFactor;

Review comment:
       My bad I reworked my patch and forgot to clean this.

##########
File path: include/mesos/allocator/allocator.hpp
##########
@@ -28,6 +28,8 @@
 
 #include <mesos/quota/quota.hpp>
 
+#include <master/constants.hpp>

Review comment:
       So the flags defined for master will depend on `include/allocator/allocator.hpp` header
(instead of the more generic `constants.hpp`? Is that ok?

##########
File path: src/master/flags.cpp
##########
@@ -460,6 +460,18 @@ mesos::internal::master::Flags::Flags()
       "load an alternate allocator module using `--modules`.",
       DEFAULT_ALLOCATOR);
 
+  add(&Flags::hierarchical_recovery_factor,
+      "hierarchical_recovery_factor",
+      "Ratio of minimal re-registred agent before sending\n"

Review comment:
       You're right; I used your sentence it seems fine to me too.

##########
File path: src/master/allocator/mesos/hierarchical.hpp
##########
@@ -755,6 +755,8 @@ class HierarchicalAllocatorProcess : public MesosAllocatorProcess
 
   // Recovery data.
   Option<int> expectedAgentCount;
+  float agentRecoveryFactor;

Review comment:
       My bad I reworked my patch and forgot to clean this.

##########
File path: include/mesos/allocator/allocator.hpp
##########
@@ -28,6 +28,8 @@
 
 #include <mesos/quota/quota.hpp>
 
+#include <master/constants.hpp>

Review comment:
       So the flags defined for master will depend on `include/allocator/allocator.hpp` header
(instead of the more generic `constants.hpp`? Is that ok?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message