From reviews-return-92472-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 31 18:52:43 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id A5DA71A82B for ; Mon, 31 Aug 2020 18:52:43 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id B98CC123D6B for ; Mon, 31 Aug 2020 18:52:42 +0000 (UTC) Received: (qmail 23377 invoked by uid 500); 31 Aug 2020 18:52:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23364 invoked by uid 500); 31 Aug 2020 18:52:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23342 invoked by uid 99); 31 Aug 2020 18:52:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2020 18:52:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6C69E1807AA for ; Mon, 31 Aug 2020 18:52:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZDmg6ilNBNkb for ; Mon, 31 Aug 2020 18:52:40 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 7D01A7F95B for ; Mon, 31 Aug 2020 18:52:39 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id E19341603B3; Mon, 31 Aug 2020 18:52:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8943647709937740013==" MIME-Version: 1.0 Subject: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Mon, 31 Aug 2020 18:52:38 -0000 Message-ID: <20200831185238.2546.93396@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72825/ X-Sender: Andrei Sekretenko Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============8943647709937740013== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72825/ ----------------------------------------------------------- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10166 https://issues.apache.org/jira/browse/MESOS-10166 Repository: mesos Description ------- This test verifies that calling UPDATE_FRAMEWORK with no changes in `FrameworkInfo` (i.e. to change suppressed roles or offer constraints) results in no API event FRAMEWORK_UPDATED sent to the subscribers and no `UpdatedFrameworkMessage` broadcast to the agents. Diffs ----- src/tests/master/update_framework_tests.cpp 6346a4eaf2b6c70d1a7d5f32706e781436d36521 Diff: https://reviews.apache.org/r/72825/diff/1/ Testing ------- `src/mesos-tests --gtest_filter='UpdateFrameworkTest.NoRedundantUpdates' --gtest_repeat=300` Thanks, Andrei Sekretenko --===============8943647709937740013==--