From reviews-return-92459-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 28 12:53:21 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id F1BD81930C for ; Fri, 28 Aug 2020 12:53:20 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id BDD4C63EA2 for ; Fri, 28 Aug 2020 12:53:19 +0000 (UTC) Received: (qmail 57984 invoked by uid 500); 28 Aug 2020 12:53:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57949 invoked by uid 500); 28 Aug 2020 12:53:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57895 invoked by uid 99); 28 Aug 2020 12:53:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Aug 2020 12:53:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C9FAB1A4683 for ; Fri, 28 Aug 2020 12:41:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.113 X-Spam-Level: ** X-Spam-Status: No, score=2.113 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id s8K4B9iAzbtZ for ; Fri, 28 Aug 2020 12:41:20 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 2FA867F702 for ; Fri, 28 Aug 2020 12:41:20 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 11A1E160350; Fri, 28 Aug 2020 12:41:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4944927648576889886==" MIME-Version: 1.0 Subject: Re: Review Request 72786: Implemented regex-based offer constraints. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Fri, 28 Aug 2020 12:41:07 -0000 Message-ID: <20200828124107.26191.42254@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72786/ X-Sender: Andrei Sekretenko References: <20200827115241.26191.87168@reviews-vm-he-fi.apache.org> In-Reply-To: <20200827115241.26191.87168@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============4944927648576889886== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72786/ ----------------------------------------------------------- (Updated Aug. 28, 2020, 12:41 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Moved the `OfferConstraintsFilter::Options` definition into `allocator.hpp`. Left TODO for considering decoupling the filter creation interface in case it doesn't eventually get decoupled for other reasons. Bugs: MESOS-10173 https://issues.apache.org/jira/browse/MESOS-10173 Repository: mesos Description ------- Implemented regex-based offer constraints. Diffs (updated) ----- include/mesos/allocator/allocator.hpp 05d0e9c46485c3048a65d46747d56e715883a0b3 src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b src/master/allocator/mesos/offer_constraints_filter.cpp d724fd0a9832feea26f6db1a498b6bdee83ffff0 src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e src/tests/master/offer_constraints_filter_tests.cpp 84a1e917a52d0b98f979e454c2b982c6402b0176 Diff: https://reviews.apache.org/r/72786/diff/10/ Changes: https://reviews.apache.org/r/72786/diff/9-10/ Testing ------- Thanks, Andrei Sekretenko --===============4944927648576889886==--