From reviews-return-92441-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 26 12:33:14 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 528211A934 for ; Wed, 26 Aug 2020 12:33:12 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id E747A125554 for ; Wed, 26 Aug 2020 12:33:11 +0000 (UTC) Received: (qmail 28604 invoked by uid 500); 26 Aug 2020 12:33:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 28582 invoked by uid 500); 26 Aug 2020 12:33:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28512 invoked by uid 99); 26 Aug 2020 12:33:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2020 12:33:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EEE411A4233 for ; Wed, 26 Aug 2020 12:24:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.112 X-Spam-Level: ** X-Spam-Status: No, score=2.112 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id EY3BboV9xFak for ; Wed, 26 Aug 2020 12:24:00 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 4384E7FB58 for ; Wed, 26 Aug 2020 12:24:00 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 9296C1603AA; Wed, 26 Aug 2020 12:23:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2024552555682986831==" MIME-Version: 1.0 Subject: Re: Review Request 72786: Implemented regex-based offer constraints. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 26 Aug 2020 12:23:59 -0000 Message-ID: <20200826122359.26190.42659@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72786/ X-Sender: Andrei Sekretenko References: <20200825184312.26190.14717@reviews-vm-he-fi.apache.org> In-Reply-To: <20200825184312.26190.14717@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/master/allocator/mesos/offer_constraints_filter.hpp Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============2024552555682986831== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72786/ ----------------------------------------------------------- (Updated Aug. 26, 2020, 12:23 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Replaced filter factory with `create()` options. Bugs: MESOS-10173 https://issues.apache.org/jira/browse/MESOS-10173 Repository: mesos Description ------- Implemented regex-based offer constraints. Diffs (updated) ----- include/mesos/allocator/allocator.hpp 05d0e9c46485c3048a65d46747d56e715883a0b3 src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b src/master/allocator/mesos/offer_constraints_filter.hpp PRE-CREATION src/master/allocator/mesos/offer_constraints_filter.cpp d724fd0a9832feea26f6db1a498b6bdee83ffff0 src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e src/tests/master/offer_constraints_filter_tests.cpp 84a1e917a52d0b98f979e454c2b982c6402b0176 Diff: https://reviews.apache.org/r/72786/diff/7/ Changes: https://reviews.apache.org/r/72786/diff/6-7/ Testing ------- Thanks, Andrei Sekretenko --===============2024552555682986831==--