From reviews-return-92422-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 25 12:39:25 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id BD2821A259 for ; Tue, 25 Aug 2020 12:39:25 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 6777F124B2E for ; Tue, 25 Aug 2020 12:39:25 +0000 (UTC) Received: (qmail 75884 invoked by uid 500); 25 Aug 2020 12:39:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 75861 invoked by uid 500); 25 Aug 2020 12:39:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 75839 invoked by uid 99); 25 Aug 2020 12:39:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Aug 2020 12:39:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 08A8BC0E0A for ; Tue, 25 Aug 2020 12:39:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.86 X-Spam-Level: * X-Spam-Status: No, score=1.86 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.248, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fG8pTDnyd-3m for ; Tue, 25 Aug 2020 12:39:22 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 1B34E7FB45 for ; Tue, 25 Aug 2020 12:39:22 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 749DD1603AA; Tue, 25 Aug 2020 12:39:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2983629961170164051==" MIME-Version: 1.0 Subject: Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality. From: Andrei Sekretenko To: Benjamin Mahler Cc: Mesos Reviewbot , Andrei Sekretenko , mesos Date: Tue, 25 Aug 2020 12:39:21 -0000 Message-ID: <20200825123921.26190.66053@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72776/ X-Sender: Andrei Sekretenko References: <20200824211405.26190.73385@reviews-vm-he-fi.apache.org> In-Reply-To: <20200824211405.26190.73385@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============2983629961170164051== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 24, 2020, 9:14 p.m., Benjamin Mahler wrote: > > Do we also want to be checking pseudoattributes? (Different enums and handling optionality (e.g. domain)). We surely need. Added https://issues.apache.org/jira/browse/MESOS-10180 to the epic for this (and for other poorly covered functionality). - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72776/#review221695 ----------------------------------------------------------- On Aug. 24, 2020, 7:35 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72776/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2020, 7:35 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10172 > https://issues.apache.org/jira/browse/MESOS-10172 > > > Repository: mesos > > > Description > ------- > > Added basic tests for offer constraints on a string attribute equality. > > > Diffs > ----- > > src/tests/master/offer_constraints_filter_tests.cpp f88e2011bc510323344ffe58fd550b7683242950 > > > Diff: https://reviews.apache.org/r/72776/diff/4/ > > > Testing > ------- > > `support/mesos-gtest-runner.py src/mesos-tests` > > > Thanks, > > Andrei Sekretenko > > --===============2983629961170164051==--