From reviews-return-92366-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 20 18:02:53 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id D9A6A1A85C for ; Thu, 20 Aug 2020 18:02:52 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 8AA3E125F64 for ; Thu, 20 Aug 2020 18:02:52 +0000 (UTC) Received: (qmail 65008 invoked by uid 500); 20 Aug 2020 18:02:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64984 invoked by uid 500); 20 Aug 2020 18:02:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64971 invoked by uid 99); 20 Aug 2020 18:02:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2020 18:02:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 41F68181446 for ; Thu, 20 Aug 2020 18:02:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JVBEzHPKafUv for ; Thu, 20 Aug 2020 18:02:48 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 8E83F7FBF4 for ; Thu, 20 Aug 2020 18:02:47 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 9CD1D160ECC; Thu, 20 Aug 2020 18:02:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0221166776982122210==" MIME-Version: 1.0 Subject: Re: Review Request 72742: Added basic tests for the `OfferConstraintsFilter`. From: Benjamin Mahler To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Thu, 20 Aug 2020 18:02:46 -0000 Message-ID: <20200820180246.26191.66078@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated In-Reply-To: <20200819120014.26190.64087@reviews-vm-he-fi.apache.org> X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72742/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20200819120014.26190.64087@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/tests/master/offer_constraints_filter_tests.cpp X-ReviewBoard-ShipIt-Only: 1 Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos Sender: Benjamin Mahler --===============0221166776982122210== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/#review221662 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Mahler On Aug. 19, 2020, noon, Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72742/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2020, noon) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > Added basic tests for the `OfferConstraintsFilter`. > > > Diffs > ----- > > src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836 > src/tests/CMakeLists.txt cf579f8d6e5176e0d4eadabcbadcbb99aa6c737e > src/tests/master/offer_constraints_filter_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72742/diff/4/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============0221166776982122210==--