From reviews-return-92362-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 20 17:06:57 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by minotaur.apache.org (Postfix) with ESMTP id 6C2A81A642 for ; Thu, 20 Aug 2020 17:06:57 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 144D641A71 for ; Thu, 20 Aug 2020 17:06:57 +0000 (UTC) Received: (qmail 62670 invoked by uid 500); 20 Aug 2020 17:06:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 62645 invoked by uid 500); 20 Aug 2020 17:06:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62628 invoked by uid 99); 20 Aug 2020 17:06:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2020 17:06:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E0755C0701 for ; Thu, 20 Aug 2020 17:06:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.861 X-Spam-Level: * X-Spam-Status: No, score=1.861 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id QqvXr_tstfkE for ; Thu, 20 Aug 2020 17:06:54 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 689ACBEF66 for ; Thu, 20 Aug 2020 17:06:52 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 6EF22160ECC; Thu, 20 Aug 2020 17:06:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0377906153380484187==" MIME-Version: 1.0 Subject: Review Request 72791: Reverted removal of the PullingSameImageSimutanuously test. From: Andrei Sekretenko To: Qian Zhang Cc: Andrei Sekretenko , mesos Date: Thu, 20 Aug 2020 17:06:51 -0000 Message-ID: <20200820170651.26190.96859@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72791/ X-Sender: Andrei Sekretenko Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============0377906153380484187== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72791/ ----------------------------------------------------------- Review request for mesos and Qian Zhang. Bugs: MESOS-10169 https://issues.apache.org/jira/browse/MESOS-10169 Repository: mesos Description ------- Now that the docker store triggers pull at most once per multiple simultaneous requests to the store, removal of the `PullingSameImageSimutanuously` test in 33c61a1907129126f3b2e37b1f53827a04e89a34 can be reverted. Diffs ----- src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc Diff: https://reviews.apache.org/r/72791/diff/1/ Testing ------- Thanks, Andrei Sekretenko --===============0377906153380484187==--