> On Aug. 17, 2020, 10:03 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 76 (patched) > > > > > > Hm.. not obvious to me why we need this, can you explain in a comment? > > Andrei Sekretenko wrote: > Changed to the alternative (`=default`ed constructors/destructor after `OfferConstraintsFilterImpl`), hopefully that one requres fewer comments. > > Please take a look; maybe even that alternative should be explained more extensively than I do in this patch. Looks good - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/#review221607 ----------------------------------------------------------- On Aug. 18, 2020, 6:01 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72741/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2020, 6:01 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > This patch implements an offer filtering object that supports the > Exists/NotExists offer constraints, and adds it into the allocator > interface. > > More constraints will be added to this filter in further patches. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 > src/CMakeLists.txt a976dc12328f42d2268b4b5d86a934bf0c754594 > src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836 > src/master/allocator/mesos/offer_constraints_filter.cpp PRE-CREATION > src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb > > > Diff: https://reviews.apache.org/r/72741/diff/5/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >