From reviews-return-92339-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 19 21:30:13 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id D2F8C19E03 for ; Wed, 19 Aug 2020 21:30:13 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 7A8CC124D0F for ; Wed, 19 Aug 2020 21:30:13 +0000 (UTC) Received: (qmail 6735 invoked by uid 500); 19 Aug 2020 21:30:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 6701 invoked by uid 500); 19 Aug 2020 21:30:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 6683 invoked by uid 99); 19 Aug 2020 21:30:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2020 21:30:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0357C18145D for ; Wed, 19 Aug 2020 21:30:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.862 X-Spam-Level: * X-Spam-Status: No, score=1.862 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id sYeucX0xcGts for ; Wed, 19 Aug 2020 21:30:10 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 2626CBEF75 for ; Wed, 19 Aug 2020 21:30:10 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 7C523160ECC; Wed, 19 Aug 2020 21:30:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0609163190797283508==" MIME-Version: 1.0 Subject: Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates. From: Benjamin Mahler To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 19 Aug 2020 21:30:02 -0000 Message-ID: <20200819213002.26190.82274@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72741/ X-Sender: Benjamin Mahler References: <20200817220304.26191.58114@reviews-vm-he-fi.apache.org> In-Reply-To: <20200817220304.26191.58114@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/master/allocator/mesos/offer_constraints_filter.cpp Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============0609163190797283508== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 17, 2020, 10:03 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 76 (patched) > > > > > > Hm.. not obvious to me why we need this, can you explain in a comment? > > Andrei Sekretenko wrote: > Changed to the alternative (`=default`ed constructors/destructor after `OfferConstraintsFilterImpl`), hopefully that one requres fewer comments. > > Please take a look; maybe even that alternative should be explained more extensively than I do in this patch. Looks good - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/#review221607 ----------------------------------------------------------- On Aug. 18, 2020, 6:01 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72741/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2020, 6:01 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > This patch implements an offer filtering object that supports the > Exists/NotExists offer constraints, and adds it into the allocator > interface. > > More constraints will be added to this filter in further patches. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 > src/CMakeLists.txt a976dc12328f42d2268b4b5d86a934bf0c754594 > src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836 > src/master/allocator/mesos/offer_constraints_filter.cpp PRE-CREATION > src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb > > > Diff: https://reviews.apache.org/r/72741/diff/5/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============0609163190797283508==--