From reviews-return-92332-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 19 18:18:11 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id EF8EB19634 for ; Wed, 19 Aug 2020 18:18:10 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 90EC21258D8 for ; Wed, 19 Aug 2020 18:18:10 +0000 (UTC) Received: (qmail 68487 invoked by uid 500); 19 Aug 2020 18:18:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 68471 invoked by uid 500); 19 Aug 2020 18:18:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 68449 invoked by uid 99); 19 Aug 2020 18:18:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2020 18:18:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3F00E18145D for ; Wed, 19 Aug 2020 18:18:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.611 X-Spam-Level: * X-Spam-Status: No, score=1.611 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id j4V-tcVFKuue for ; Wed, 19 Aug 2020 18:18:07 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 350A87FBC3 for ; Wed, 19 Aug 2020 18:18:07 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 5942C160ECC; Wed, 19 Aug 2020 18:18:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8059274087932611068==" MIME-Version: 1.0 Subject: Re: Review Request 72744: Added a scheduler API test for a valid offer constraints update. From: Benjamin Mahler To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 19 Aug 2020 18:18:06 -0000 Message-ID: <20200819181806.26191.18972@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72744/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20200814165909.6277.30415@reviews-vm-he-fi.apache.org> In-Reply-To: <20200814165909.6277.30415@reviews-vm-he-fi.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============8059274087932611068== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72744/#review221643 ----------------------------------------------------------- Ship it! src/tests/master/update_framework_tests.cpp Lines 755 (patched) Maybe this is more consistent? ``` EXPECT_CALL(*scheduler, connected(_)) .WillOnce(Invoke([](Mesos* mesos) { XXX })); ``` src/tests/master/update_framework_tests.cpp Lines 761-770 (patched) Per comment on previous review, could consider using json for this? (ditto below) src/tests/master/update_framework_tests.cpp Lines 789-798 (patched) Hm.. I would have guessed this reads from the /frameworks endpoint (or v1 GET_FRAMEWORKS call) to check the state change. Testing that it gets propagated to the allocator also make sense though. Perhaps we should check both? - Benjamin Mahler On Aug. 14, 2020, 4:59 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72744/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:59 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > Added a scheduler API test for a valid offer constraints update. > > > Diffs > ----- > > src/tests/master/update_framework_tests.cpp 514647dd2fbd4b901b5f57a81fded949af12432a > > > Diff: https://reviews.apache.org/r/72744/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============8059274087932611068==--