From reviews-return-92326-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 19 13:27:32 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 8AC361A7F4 for ; Wed, 19 Aug 2020 13:27:31 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 55B161256E6 for ; Wed, 19 Aug 2020 13:27:31 +0000 (UTC) Received: (qmail 9728 invoked by uid 500); 19 Aug 2020 13:27:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 9715 invoked by uid 500); 19 Aug 2020 13:27:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 9688 invoked by uid 99); 19 Aug 2020 13:27:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2020 13:27:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 10CAE1A344C for ; Wed, 19 Aug 2020 13:27:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.861 X-Spam-Level: * X-Spam-Status: No, score=1.861 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KC0wCqmylHMX for ; Wed, 19 Aug 2020 13:27:28 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id BE613BEF75 for ; Wed, 19 Aug 2020 13:27:27 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id A9545160ECC; Wed, 19 Aug 2020 13:27:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0508773857134718322==" MIME-Version: 1.0 Subject: Re: Review Request 72774: Wired up the `OfferConstraintsFilter` into the hierarchical allocator. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 19 Aug 2020 13:27:26 -0000 Message-ID: <20200819132726.26190.50983@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72774/ X-Sender: Andrei Sekretenko References: <20200814165601.6277.60319@reviews-vm-he-fi.apache.org> In-Reply-To: <20200814165601.6277.60319@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============0508773857134718322== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72774/ ----------------------------------------------------------- (Updated Aug. 19, 2020, 1:27 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-10171 https://issues.apache.org/jira/browse/MESOS-10171 Repository: mesos Description ------- Wired up the `OfferConstraintsFilter` into the hierarchical allocator. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp e444e470eb085cea167f84f8540d1769d662c222 src/master/allocator/mesos/hierarchical.cpp 9e5079942263132d09c6bd9abbdc8858cd2ef138 Diff: https://reviews.apache.org/r/72774/diff/3/ Changes: https://reviews.apache.org/r/72774/diff/2-3/ Testing ------- Thanks, Andrei Sekretenko --===============0508773857134718322==--