From reviews-return-92304-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 18 18:42:18 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id DB3401AB0F for ; Tue, 18 Aug 2020 18:42:17 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 8B754124E63 for ; Tue, 18 Aug 2020 18:42:17 +0000 (UTC) Received: (qmail 34405 invoked by uid 500); 18 Aug 2020 18:42:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34357 invoked by uid 500); 18 Aug 2020 18:42:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34340 invoked by uid 99); 18 Aug 2020 18:42:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Aug 2020 18:42:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4E755C03A4 for ; Tue, 18 Aug 2020 18:42:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.86 X-Spam-Level: * X-Spam-Status: No, score=1.86 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id z5fBwD4HX2oQ for ; Tue, 18 Aug 2020 18:42:15 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id C7606BE386 for ; Tue, 18 Aug 2020 18:42:14 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 38994160ECC; Tue, 18 Aug 2020 18:42:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9196748739166087608==" MIME-Version: 1.0 Subject: Re: Review Request 72742: Added basic tests for the `OfferConstraintsFilter`. From: Andrei Sekretenko To: Benjamin Mahler Cc: Mesos Reviewbot , Andrei Sekretenko , mesos Date: Tue, 18 Aug 2020 18:42:13 -0000 Message-ID: <20200818184213.26190.12645@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72742/ X-Sender: Andrei Sekretenko References: <20200818183651.26190.44045@reviews-vm-he-fi.apache.org> In-Reply-To: <20200818183651.26190.44045@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/tests/master/offer_constraints_filter_tests.cpp Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============9196748739166087608== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 18, 2020, 6:36 p.m., Benjamin Mahler wrote: > > Great to have unit tests for this! Mainly left a suggestion about using a JSON approach to build the protobuf. > > > > Do we want to add another test here for attributes with multiple entries? (i.e. showing that we only look at the first entry) The test for multiple attributes is in https://reviews.apache.org/r/72776, after the equality constraints are implemented; I don't see how to add such a test without a constraint on the value. JSON looks like a good idea, will try that. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/#review221625 ----------------------------------------------------------- On Aug. 14, 2020, 4:59 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72742/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:59 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > Added basic tests for the `OfferConstraintsFilter`. > > > Diffs > ----- > > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/tests/CMakeLists.txt cf579f8d6e5176e0d4eadabcbadcbb99aa6c737e > src/tests/master/offer_constraints_filter_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72742/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============9196748739166087608==--