From reviews-return-92276-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 17 21:31:01 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id A36D619A6B for ; Mon, 17 Aug 2020 21:30:59 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 4D6F812476F for ; Mon, 17 Aug 2020 21:30:59 +0000 (UTC) Received: (qmail 51558 invoked by uid 500); 17 Aug 2020 21:30:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51539 invoked by uid 500); 17 Aug 2020 21:30:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51521 invoked by uid 99); 17 Aug 2020 21:30:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2020 21:30:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F0A9C1A42AE for ; Mon, 17 Aug 2020 21:30:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.861 X-Spam-Level: * X-Spam-Status: No, score=1.861 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id hiKuR0gSkFyh for ; Mon, 17 Aug 2020 21:30:56 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 817AAC1807 for ; Mon, 17 Aug 2020 21:30:56 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id AD512160F34; Mon, 17 Aug 2020 21:30:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3572061021099328526==" MIME-Version: 1.0 Subject: Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering. From: Benjamin Mahler To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Mon, 17 Aug 2020 21:30:55 -0000 Message-ID: <20200817213055.26190.3962@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72738/ X-Sender: Benjamin Mahler References: <20200814163635.14498.44001@reviews-vm-he-fi.apache.org> In-Reply-To: <20200814163635.14498.44001@reviews-vm-he-fi.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============3572061021099328526== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/#review221606 ----------------------------------------------------------- include/mesos/scheduler/scheduler.proto Lines 261-264 (patched) Thanks for documenting the subtlety here! Perhaps say that we do not advise using multiple attributes with the same name. (maybe also a TODO that if it becomes a problem we could add a `lookup_mode`, but oy.. I would try really hard to avoid that). - Benjamin Mahler On Aug. 14, 2020, 4:36 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72738/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:36 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > This patch adds framework's offer constraints into `Subscribe` and > `UpdateFramework` calls, which is a prerequisite to implementing > constraints-based offer filtering (see MESOS-10161). > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc > include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3 > src/internal/devolve.cpp 4527c522473b74622055e1765740e3706b95afdb > > > Diff: https://reviews.apache.org/r/72738/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============3572061021099328526==--