From reviews-return-92274-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 17 20:32:38 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 42287198E0 for ; Mon, 17 Aug 2020 20:32:38 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id DC881124925 for ; Mon, 17 Aug 2020 20:32:37 +0000 (UTC) Received: (qmail 78009 invoked by uid 500); 17 Aug 2020 20:32:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 77983 invoked by uid 500); 17 Aug 2020 20:32:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77932 invoked by uid 99); 17 Aug 2020 20:32:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2020 20:32:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 93A22181494 for ; Mon, 17 Aug 2020 20:32:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.111 X-Spam-Level: ** X-Spam-Status: No, score=2.111 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id D_eumeVuDSeX for ; Mon, 17 Aug 2020 20:32:35 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id ABB44BEF7E for ; Mon, 17 Aug 2020 20:23:39 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 88213160F31; Mon, 17 Aug 2020 20:23:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9137219442249235805==" MIME-Version: 1.0 Subject: Review Request 72786: Implemented regex-based offer constraints. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Mon, 17 Aug 2020 20:23:38 -0000 Message-ID: <20200817202338.26190.2991@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72786/ X-Sender: Andrei Sekretenko X-ReviewBoard-Diff-For: src/tests/master/offer_constraints_filter_tests.cpp X-ReviewBoard-Diff-For: src/master/allocator/mesos/offer_constraints_filter.cpp Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============9137219442249235805== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72786/ ----------------------------------------------------------- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10173 https://issues.apache.org/jira/browse/MESOS-10173 Repository: mesos Description ------- Implemented regex-based offer constraints. Diffs ----- include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 src/master/allocator/mesos/offer_constraints_filter.cpp PRE-CREATION src/master/master.hpp 214307fcae47905672260758a1b96a034ed80257 src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb src/tests/master/offer_constraints_filter_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72786/diff/1/ Testing ------- Thanks, Andrei Sekretenko --===============9137219442249235805==--