From reviews-return-92247-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 14 16:42:44 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 7B47C1994A for ; Fri, 14 Aug 2020 16:42:44 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 28C3812613C for ; Fri, 14 Aug 2020 16:42:44 +0000 (UTC) Received: (qmail 94272 invoked by uid 500); 14 Aug 2020 16:42:44 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 94248 invoked by uid 500); 14 Aug 2020 16:42:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 94229 invoked by uid 99); 14 Aug 2020 16:42:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Aug 2020 16:42:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E886A1A00ED for ; Fri, 14 Aug 2020 16:42:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.465 X-Spam-Level: * X-Spam-Status: No, score=1.465 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ilRpHZoFso4i for ; Fri, 14 Aug 2020 16:42:40 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id B76F37FA55 for ; Fri, 14 Aug 2020 16:42:39 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id DB833160F31; Fri, 14 Aug 2020 16:42:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4421935958226265064==" MIME-Version: 1.0 Subject: Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Fri, 14 Aug 2020 16:42:38 -0000 Message-ID: <20200814164238.14498.39266@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72741/ X-Sender: Andrei Sekretenko References: <20200806162418.14033.5643@reviews-vm-he-fi.apache.org> In-Reply-To: <20200806162418.14033.5643@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/master/allocator/mesos/offer_constraints_filter.cpp Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============4421935958226265064== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72741/ ----------------------------------------------------------- (Updated Aug. 14, 2020, 4:42 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- - Incorporated reworked part of https://reviews.apache.org/r/72740 (I'm discarding that PR) - Now that the `OfferConstraintsFilter` is declared in `include/../allocator.hpp`, I'm relocating `offer_constraints_filter.cpp` - addressed feedback on this one Bugs: MESOS-10171 https://issues.apache.org/jira/browse/MESOS-10171 Repository: mesos Description (updated) ------- This patch implements an offer filtering object that supports the Exists/NotExists offer constraints, and adds it into the allocator interface. More constraints will be added to this filter in further patches. Diffs (updated) ----- include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 src/master/allocator/mesos/offer_constraints_filter.cpp PRE-CREATION src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb Diff: https://reviews.apache.org/r/72741/diff/2/ Changes: https://reviews.apache.org/r/72741/diff/1-2/ Testing ------- Thanks, Andrei Sekretenko --===============4421935958226265064==--