From reviews-return-92246-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 14 16:37:23 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id A237819924 for ; Fri, 14 Aug 2020 16:37:23 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 4F492126361 for ; Fri, 14 Aug 2020 16:37:23 +0000 (UTC) Received: (qmail 86477 invoked by uid 500); 14 Aug 2020 16:37:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86454 invoked by uid 500); 14 Aug 2020 16:37:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86437 invoked by uid 99); 14 Aug 2020 16:37:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Aug 2020 16:37:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 318981A4200 for ; Fri, 14 Aug 2020 16:37:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.464 X-Spam-Level: * X-Spam-Status: No, score=1.464 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id itQq2D_mlb9w for ; Fri, 14 Aug 2020 16:37:20 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 751AFBE402 for ; Fri, 14 Aug 2020 16:37:20 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 76303160F31; Fri, 14 Aug 2020 16:37:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7193286322147797994==" MIME-Version: 1.0 Subject: Re: Review Request 72739: Introduced a `FrameworkOptions` struct into the allocator interface. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Fri, 14 Aug 2020 16:37:19 -0000 Message-ID: <20200814163719.14033.5927@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72739/ X-Sender: Andrei Sekretenko References: <20200806163231.14033.83766@reviews-vm-he-fi.apache.org> In-Reply-To: <20200806163231.14033.83766@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============7193286322147797994== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72739/ ----------------------------------------------------------- (Updated Aug. 14, 2020, 4:37 p.m.) Review request for mesos and Benjamin Mahler. Bugs: MESOS-10171 https://issues.apache.org/jira/browse/MESOS-10171 Repository: mesos Description ------- This patch supersedes the `suppressedRoles` parameter of the `addFramework()`/`updateFramework()` allocator methods with a more general `FrameworkOptions` struct that will allow to add more allocation options that are of no interest to agents (and thus are not included into the `FrameworkInfo` protobuf). Diffs (updated) ----- include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 src/master/allocator/mesos/allocator.hpp dd7952b55958a3f323b9ab103db846b85db79f36 src/master/allocator/mesos/hierarchical.hpp e444e470eb085cea167f84f8540d1769d662c222 src/master/allocator/mesos/hierarchical.cpp 9e5079942263132d09c6bd9abbdc8858cd2ef138 src/master/master.hpp 214307fcae47905672260758a1b96a034ed80257 src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb src/tests/allocator.hpp 476560427a50e3f7d21d170f1d3a72290328852a src/tests/master_allocator_tests.cpp d2580c34452829eb8ae04e81c2dbbe6a13dde40e src/tests/reservation_tests.cpp cd84cd24d3587fafc01ae1861f22c47262f2d7e9 src/tests/resource_offers_tests.cpp 08bb10957007a8af583157f5db365bd59a39c814 src/tests/slave_recovery_tests.cpp da163a2e06ccde6ea05bf6717bea184e81844a4d Diff: https://reviews.apache.org/r/72739/diff/2/ Changes: https://reviews.apache.org/r/72739/diff/1-2/ Testing ------- Thanks, Andrei Sekretenko --===============7193286322147797994==--