From reviews-return-92232-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 13 18:54:06 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id DDDC21AE93 for ; Thu, 13 Aug 2020 18:54:06 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 8CDEF1260A7 for ; Thu, 13 Aug 2020 18:54:06 +0000 (UTC) Received: (qmail 95656 invoked by uid 500); 13 Aug 2020 18:54:06 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 95643 invoked by uid 500); 13 Aug 2020 18:54:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 95606 invoked by uid 99); 13 Aug 2020 18:54:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2020 18:54:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 49A64C06C9 for ; Thu, 13 Aug 2020 18:54:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.464 X-Spam-Level: * X-Spam-Status: No, score=1.464 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xWtUuAXfm4Wf for ; Thu, 13 Aug 2020 18:54:04 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id A7C297F9BE for ; Thu, 13 Aug 2020 18:54:03 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id EAAF2160197; Thu, 13 Aug 2020 18:54:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1734840139577167941==" MIME-Version: 1.0 Subject: Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering. From: Andrei Sekretenko To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Thu, 13 Aug 2020 18:54:02 -0000 Message-ID: <20200813185402.14033.69367@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72738/ X-Sender: Andrei Sekretenko References: <20200806163320.14033.27427@reviews-vm-he-fi.apache.org> In-Reply-To: <20200806163320.14033.27427@reviews-vm-he-fi.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============1734840139577167941== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/ ----------------------------------------------------------- (Updated Aug. 13, 2020, 6:54 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Accommodated the suggested explanation if the constraints structure (with slight adjustments). Checked for suppressed_roles once again and found `evolve()`; inserted a patch before this one to remove that. Bugs: MESOS-10171 https://issues.apache.org/jira/browse/MESOS-10171 Repository: mesos Description ------- This patch adds framework's offer constraints into `Subscribe` and `UpdateFramework` calls, which is a prerequisite to implementing constraints-based offer filtering (see MESOS-10161). Diffs (updated) ----- include/mesos/scheduler/scheduler.proto 6e1639a9baf017fa87b274daeedc821389216ddc include/mesos/v1/scheduler/scheduler.proto eb5fdeb984b28403bd8281742bd0a5f2053863e3 src/internal/devolve.cpp 4527c522473b74622055e1765740e3706b95afdb Diff: https://reviews.apache.org/r/72738/diff/2/ Changes: https://reviews.apache.org/r/72738/diff/1-2/ Testing ------- Thanks, Andrei Sekretenko --===============1734840139577167941==--