From reviews-return-92220-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 13 02:42:58 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id CF0591AE16 for ; Thu, 13 Aug 2020 02:42:58 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 7BF66125389 for ; Thu, 13 Aug 2020 02:42:58 +0000 (UTC) Received: (qmail 72951 invoked by uid 500); 13 Aug 2020 02:42:58 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 72910 invoked by uid 500); 13 Aug 2020 02:42:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72893 invoked by uid 99); 13 Aug 2020 02:42:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2020 02:42:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9F56F18144E for ; Thu, 13 Aug 2020 02:42:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.165 X-Spam-Level: **** X-Spam-Status: No, score=4.165 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_NONE=0.25, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.001, NML_ADSP_CUSTOM_MED=1.2, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 54SN3Sv2Tfm6 for ; Thu, 13 Aug 2020 02:42:55 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id AF11E7F731 for ; Thu, 13 Aug 2020 02:42:54 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id B7EF2160195; Thu, 13 Aug 2020 02:42:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0539471088312056385==" MIME-Version: 1.0 Subject: Re: Review Request 72761: Added the CSI server to the Mesos agent. From: Qian Zhang To: Qian Zhang Cc: Greg Mann , mesos Date: Thu, 13 Aug 2020 02:42:53 -0000 Message-ID: <20200813024253.6277.86585@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72761/ X-Sender: Qian Zhang References: <20200812191948.14033.55909@reviews-vm-he-fi.apache.org> In-Reply-To: <20200812191948.14033.55909@reviews-vm-he-fi.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============0539471088312056385== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221560 ----------------------------------------------------------- src/slave/main.cpp Lines 577 (patched) This seems not correct to me, `process::network::inet4::Address::ANY_ANY().ip` is something like `0.0.0.0`, right? I think here we should use the actual IP the agent listens on, I see we set the env var `LIBPROCESS_IP` at line 336, maybe we should use that as the agent IP here? And if `os::getenv("LIBPROCESS_IP")` returns `None` then we should use `process::network::inet4::Address::LOOPBACK_ANY().ip`. Ditto for the same code in `src/tests/cluster.cpp`. src/slave/slave.hpp Lines 892 (patched) Why does slave need CSI server as its member? src/tests/cluster.hpp Lines 59 (patched) This line should be put below the line `#include "slave/constants.hpp"`. - Qian Zhang On Aug. 13, 2020, 3:19 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72761/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2020, 3:19 a.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > This patch adds a CSI server to the Mesos agent in both > the agent binary and in tests. > > > Diffs > ----- > > src/local/local.cpp 895057027165609c792089cd336988b65a3b305d > src/slave/main.cpp 0aa2cc9d254d0b74485a0584b9f55c2266f29367 > src/slave/slave.hpp 2cf45c616d5c50508bc5cd77096b0fef86542b1d > src/slave/slave.cpp c828d99ca9909b904767cc9ea5671b462714f547 > src/tests/cluster.hpp 415a60f5fd4881bca329ffd718f58d676653a17d > src/tests/cluster.cpp ab4cea49eb3e8cf18d320fbb30beaa3c454a08b0 > src/tests/mesos.hpp 0ad0999fba185539c90b053bda43be001da26253 > src/tests/mesos.cpp d6933a60c55802e6f9e89242608fbfad7631faed > src/tests/mock_slave.hpp 58daefa4459eaf15c2394f14db9f94527984b2b8 > src/tests/mock_slave.cpp fa2a0f5c8dadeb8aea87815741bc4fe071d5fbe0 > > > Diff: https://reviews.apache.org/r/72761/diff/1/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > > --===============0539471088312056385==--