From reviews-return-92201-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 11 19:33:17 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id CF252198E3 for ; Tue, 11 Aug 2020 19:33:16 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 784511243A9 for ; Tue, 11 Aug 2020 19:33:16 +0000 (UTC) Received: (qmail 94385 invoked by uid 500); 11 Aug 2020 19:33:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 94364 invoked by uid 500); 11 Aug 2020 19:33:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 94347 invoked by uid 99); 11 Aug 2020 19:33:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2020 19:33:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2A804181421 for ; Tue, 11 Aug 2020 19:33:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.463 X-Spam-Level: * X-Spam-Status: No, score=1.463 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id G_P29GW0MAjZ for ; Tue, 11 Aug 2020 19:33:13 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 01C3F7DC04 for ; Tue, 11 Aug 2020 19:33:12 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 3925E160195; Tue, 11 Aug 2020 19:33:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1651411874764136490==" MIME-Version: 1.0 Subject: Re: Review Request 72739: Introduced a `FrameworkOptions` struct into the allocator interface. From: Benjamin Mahler To: Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Tue, 11 Aug 2020 19:33:12 -0000 Message-ID: <20200811193312.6277.34597@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72739/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20200806163231.14033.83766@reviews-vm-he-fi.apache.org> In-Reply-To: <20200806163231.14033.83766@reviews-vm-he-fi.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============1651411874764136490== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72739/#review221548 ----------------------------------------------------------- Ship it! Ok, so recoverFramework does not need the allocation options because the framework is inactive? Can you explain a bit about that change in the commit description? src/master/master.hpp Line 616 (original), 616 (patched) Hm.. might be able to get this out of the allocator namespace, unless you foresee more complex allocation relevant state going in there? src/master/master.cpp Lines 10048-10052 (original), 10056-10060 (patched) Hm.. not quite obvious that it's ok to pass empty allocation options here, perhaps just add a little bit of color about the invariants? (i.e. the framework won't be active?) - Benjamin Mahler On Aug. 6, 2020, 4:32 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72739/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2020, 4:32 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > This patch supersedes the `suppressedRoles` parameter of the > `addFramework()`/`updateFramework()` allocator methods with a more > general `FrameworkOptions` struct that will allow to add more > allocation options that are of no interest to agents (and thus are > not included into the `FrameworkInfo` protobuf). > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp c700528e14bb42f6cea37f42dd7b72eb76a1a6b9 > src/master/allocator/mesos/allocator.hpp dd7952b55958a3f323b9ab103db846b85db79f36 > src/master/allocator/mesos/hierarchical.hpp e444e470eb085cea167f84f8540d1769d662c222 > src/master/allocator/mesos/hierarchical.cpp 9e5079942263132d09c6bd9abbdc8858cd2ef138 > src/master/master.hpp 214307fcae47905672260758a1b96a034ed80257 > src/master/master.cpp 6a013e334b19bd108791d1c5fd0864c710aae8cb > src/tests/allocator.hpp 476560427a50e3f7d21d170f1d3a72290328852a > src/tests/master_allocator_tests.cpp d2580c34452829eb8ae04e81c2dbbe6a13dde40e > src/tests/reservation_tests.cpp cd84cd24d3587fafc01ae1861f22c47262f2d7e9 > src/tests/resource_offers_tests.cpp 08bb10957007a8af583157f5db365bd59a39c814 > src/tests/slave_recovery_tests.cpp da163a2e06ccde6ea05bf6717bea184e81844a4d > > > Diff: https://reviews.apache.org/r/72739/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > > --===============1651411874764136490==--