-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72753/#review221537
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp
Lines 101 (patched)
<https://reviews.apache.org/r/72753/#comment310591>

    Since this isn't really a continuation, I think the underscore notation is confusing. Maybe rename it something like `recoverContainer()`?



src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
Lines 155 (patched)
<https://reviews.apache.org/r/72753/#comment310592>

    Nit: s/Cleanup/Cleaning up/



src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
Lines 185 (patched)
<https://reviews.apache.org/r/72753/#comment310593>

    s/CSI volumes checkpointed/CSI volume state expected/


- Greg Mann


On Aug. 10, 2020, 1:05 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72753/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2020, 1:05 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10155
>     https://issues.apache.org/jira/browse/MESOS-10155
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the `recover` method of `volume/csi` isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72753/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>