From reviews-return-92169-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Aug 8 17:23:18 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 9A8671A7B3 for ; Sat, 8 Aug 2020 17:23:17 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id CB58B125A0F for ; Sat, 8 Aug 2020 17:23:16 +0000 (UTC) Received: (qmail 35404 invoked by uid 500); 8 Aug 2020 17:23:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 35380 invoked by uid 500); 8 Aug 2020 17:23:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 35366 invoked by uid 99); 8 Aug 2020 17:23:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Aug 2020 17:23:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 73F28181478 for ; Sat, 8 Aug 2020 17:23:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.4, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id if_yytZbiY6G for ; Sat, 8 Aug 2020 17:23:13 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 5F50F7F80C for ; Sat, 8 Aug 2020 17:23:13 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 758F016018C; Sat, 8 Aug 2020 17:23:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3237122627254361195==" MIME-Version: 1.0 Subject: Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator. From: Mesos Reviewbot To: Andrei Budnik , Greg Mann Cc: Mesos Reviewbot , Qian Zhang , mesos Date: Sat, 08 Aug 2020 17:23:12 -0000 Message-ID: <20200808172312.14033.38189@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72734/ X-Sender: Mesos Reviewbot References: <20200808151858.14498.10114@reviews-vm-he-fi.apache.org> In-Reply-To: <20200808151858.14498.10114@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============3237122627254361195== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72734/#review221509 ----------------------------------------------------------- Bad review! Reviews applied: [72734, 72733, 72690, 72716, 72707, 72715, 72681, 72672, 72661, 72660] Error: 2020-08-08 17:23:07 URL:https://reviews.apache.org/r/72733/diff/raw/ [17892/17892] -> "72733.patch" [1] error: patch failed: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp:16 error: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp: patch does not apply - Mesos Reviewbot On Aug. 8, 2020, 3:18 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72734/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2020, 3:18 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10154 > https://issues.apache.org/jira/browse/MESOS-10154 > > > Repository: mesos > > > Description > ------- > > Implemented the `cleanup` method of `volume/csi` isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72734/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============3237122627254361195==--