From reviews-return-92150-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 7 03:15:39 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 0881119866 for ; Fri, 7 Aug 2020 03:15:39 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id B21AF126987 for ; Fri, 7 Aug 2020 03:15:38 +0000 (UTC) Received: (qmail 64311 invoked by uid 500); 7 Aug 2020 03:15:38 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64296 invoked by uid 500); 7 Aug 2020 03:15:38 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64274 invoked by uid 99); 7 Aug 2020 03:15:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Aug 2020 03:15:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9B4D31814B3 for ; Fri, 7 Aug 2020 03:15:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.563 X-Spam-Level: **** X-Spam-Status: No, score=4.563 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_NONE=0.25, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.398, NML_ADSP_CUSTOM_MED=1.2, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 45F1RPTq27an for ; Fri, 7 Aug 2020 03:15:35 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id A9473BB949 for ; Fri, 7 Aug 2020 03:15:34 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id F201D16018A; Fri, 7 Aug 2020 03:15:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1140243558370946076==" MIME-Version: 1.0 Subject: Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator. From: Qian Zhang To: Andrei Budnik , Greg Mann Cc: Mesos Reviewbot , Qian Zhang , mesos Date: Fri, 07 Aug 2020 03:15:33 -0000 Message-ID: <20200807031533.14498.73634@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72733/ X-Sender: Qian Zhang References: <20200806012736.14033.92877@reviews-vm-he-fi.apache.org> In-Reply-To: <20200806012736.14033.92877@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/state.proto X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/state.hpp Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============1140243558370946076== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 6, 2020, 9:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 115-117 (patched) > > > > > > This seems pretty simple, could we do it now? > > Qian Zhang wrote: > Actually we have this issue in the other two isolators: > https://github.com/apache/mesos/blob/1.10.0/src/slave/containerizer/mesos/isolators/volume/image.cpp#L118:L123 > https://github.com/apache/mesos/blob/1.10.0/src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp#L364:L367 > > I think I can create a separate ticket for this issue and refactor all of them later, HDYT? > > Greg Mann wrote: > Personally I think it's OK to write this isolator the "correct" way now, we can always update the others later. I don't feel a need to keep our isolator implementations super consistent across isolators. Sure, let me do it for this isolator now. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221469 ----------------------------------------------------------- On Aug. 6, 2020, 5:23 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72733/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2020, 5:23 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10153 > https://issues.apache.org/jira/browse/MESOS-10153 > > > Repository: mesos > > > Description > ------- > > Implemented the `prepare` method of `volume/csi` isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/common/validation.cpp 14a8c7b9d70c303b527e5e43012999471ced2d78 > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/state.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/state.proto PRE-CREATION > > > Diff: https://reviews.apache.org/r/72733/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============1140243558370946076==--