> On Aug. 5, 2020, 6:39 a.m., Greg Mann wrote:
> > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
> > Lines 17-22 (patched)
> > <https://reviews.apache.org/r/72690/diff/6/?file=2236973#file2236973line17>
> >
> >     Missing includes for types used in this file like `string`, `Future`, etc.

Do we need to do this if we include them in the header file `csi/isolator.hpp`?


> On Aug. 5, 2020, 6:39 a.m., Greg Mann wrote:
> > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/72690/diff/6/?file=2236973#file2236973line41>
> >
> >     Should we do a check for `if (csiServer == nullptr)` in the body of `create()`?

I think we do not need to do that. Like in `EnvironmentSecretIsolatorProcess::create` and `VolumeSecretIsolatorProcess::create` we just use the pointer `secretResolver` but not check if it is a null pointer.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72690/#review221468
-----------------------------------------------------------


On Aug. 4, 2020, 4:18 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72690/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2020, 4:18 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10152
>     https://issues.apache.org/jira/browse/MESOS-10152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the framework and `create` method of `volume/csi` isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea 
>   src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/csi/paths.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72690/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>