From reviews-return-92124-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 4 22:40:00 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id EA9BE1A830 for ; Tue, 4 Aug 2020 22:39:59 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 9C2001253BA for ; Tue, 4 Aug 2020 22:39:59 +0000 (UTC) Received: (qmail 84553 invoked by uid 500); 4 Aug 2020 22:39:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 84533 invoked by uid 500); 4 Aug 2020 22:39:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84516 invoked by uid 99); 4 Aug 2020 22:39:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2020 22:39:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E3F4BC02FB for ; Tue, 4 Aug 2020 22:39:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.612 X-Spam-Level: * X-Spam-Status: No, score=1.612 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zqMpIP7uWlMH for ; Tue, 4 Aug 2020 22:39:55 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 1017EC1790 for ; Tue, 4 Aug 2020 22:39:55 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id B388E16025E; Tue, 4 Aug 2020 22:39:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0844064954857869187==" MIME-Version: 1.0 Subject: Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator. From: Greg Mann To: Andrei Budnik , Greg Mann Cc: Qian Zhang , mesos Date: Tue, 04 Aug 2020 22:39:53 -0000 Message-ID: <20200804223953.14498.55703@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72690/ X-Sender: Greg Mann References: <20200804081900.14498.30364@reviews-vm-he-fi.apache.org> In-Reply-To: <20200804081900.14498.30364@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/paths.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============0844064954857869187== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221468 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp Lines 20-25 (patched) Also need includes for `Future`, `Option`, `Nothing`, `Try`, `vector`, `string`, Mesos protos, `hashset`, `ProcessBase`, and `ContainerState` src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp Lines 17-22 (patched) Missing includes for types used in this file like `string`, `Future`, etc. src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp Lines 41 (patched) Should we do a check for `if (csiServer == nullptr)` in the body of `create()`? - Greg Mann On Aug. 4, 2020, 8:18 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72690/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2020, 8:18 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10152 > https://issues.apache.org/jira/browse/MESOS-10152 > > > Repository: mesos > > > Description > ------- > > Implemented the framework and `create` method of `volume/csi` isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/paths.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72690/diff/6/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============0844064954857869187==--