From reviews-return-92122-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 4 17:17:54 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 872E319BBC for ; Tue, 4 Aug 2020 17:17:54 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 27F3B124B44 for ; Tue, 4 Aug 2020 17:17:54 +0000 (UTC) Received: (qmail 37278 invoked by uid 500); 4 Aug 2020 17:17:54 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37188 invoked by uid 500); 4 Aug 2020 17:17:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37147 invoked by uid 99); 4 Aug 2020 17:17:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2020 17:17:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 846D4C0B7D for ; Tue, 4 Aug 2020 17:17:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.861 X-Spam-Level: * X-Spam-Status: No, score=1.861 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id nQzi5rESjwQN for ; Tue, 4 Aug 2020 17:17:51 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id A8687C176A for ; Tue, 4 Aug 2020 17:17:50 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 739E216025E; Tue, 4 Aug 2020 17:17:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4434731167668969922==" MIME-Version: 1.0 Subject: Re: Review Request 72732: Added support for secrets to the CSI server and volume manager. From: Greg Mann To: Qian Zhang , Andrei Budnik Cc: Mesos Reviewbot , Greg Mann , mesos Date: Tue, 04 Aug 2020 17:17:49 -0000 Message-ID: <20200804171749.14033.43624@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72732/ X-Sender: Greg Mann References: <20200803235307.14498.61340@reviews-vm-he-fi.apache.org> In-Reply-To: <20200803235307.14498.61340@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/slave/csi_server.cpp X-ReviewBoard-Diff-For: src/tests/csi_server_tests.cpp Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============4434731167668969922== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72732/ ----------------------------------------------------------- (Updated Aug. 4, 2020, 5:17 p.m.) Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10168 https://issues.apache.org/jira/browse/MESOS-10168 Repository: mesos Description ------- Added support for secrets to the CSI server and volume manager. Diffs (updated) ----- src/csi/state.proto 836e30c74026ef87896cbb537b14a3b97445bea1 src/csi/v0_volume_manager.hpp 93183c2b0187ceb41533c7e022f2a5ef1f23d9a1 src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423 src/csi/v0_volume_manager_process.hpp 7548c43aa982759296f1413866f14b5280404185 src/csi/v1_volume_manager.hpp 2f7897d416895f4be0efd32bdce90df9049bdf58 src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56 src/csi/v1_volume_manager_process.hpp b8a1ef7d58438633e497f86ff6604664d3a80b8c src/csi/volume_manager.hpp 57e7c51d0baf296ce5ceb0385a7da0776b3545aa src/csi/volume_manager.cpp c47adfe426419cf71dc1f2cb435aa241904ed8a2 src/slave/csi_server.hpp 17882e1be5a6c38ca34d7b50d4a6041530e8908c src/slave/csi_server.cpp PRE-CREATION src/tests/csi_server_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/72732/diff/2/ Changes: https://reviews.apache.org/r/72732/diff/1-2/ Testing ------- Thanks, Greg Mann --===============4434731167668969922==--