From reviews-return-92118-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 4 11:09:02 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@locus.apache.org Delivered-To: apmail-mesos-reviews-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id BD6B31AB0F for ; Tue, 4 Aug 2020 11:09:01 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 016471240B7 for ; Tue, 4 Aug 2020 11:09:01 +0000 (UTC) Received: (qmail 77606 invoked by uid 500); 4 Aug 2020 11:09:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 77589 invoked by uid 500); 4 Aug 2020 11:09:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77568 invoked by uid 99); 4 Aug 2020 11:09:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2020 11:09:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AD3BD1A32A1 for ; Tue, 4 Aug 2020 11:08:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.611 X-Spam-Level: * X-Spam-Status: No, score=1.611 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.398, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4CipkTYVt5GM for ; Tue, 4 Aug 2020 11:08:57 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 9C5E07FA91 for ; Tue, 4 Aug 2020 11:08:56 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id C210116025E; Tue, 4 Aug 2020 11:08:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6227370731370140591==" MIME-Version: 1.0 Subject: Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator. From: Mesos Reviewbot To: Andrei Budnik , Greg Mann Cc: Mesos Reviewbot , Qian Zhang , mesos Date: Tue, 04 Aug 2020 11:08:55 -0000 Message-ID: <20200804110855.14498.81997@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72733/ X-Sender: Mesos Reviewbot References: <20200804082011.14498.66058@reviews-vm-he-fi.apache.org> In-Reply-To: <20200804082011.14498.66058@reviews-vm-he-fi.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/state.proto X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/csi/state.hpp Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============6227370731370140591== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221464 ----------------------------------------------------------- Patch looks great! Reviews applied: [72660, 72661, 72672, 72681, 72715, 72707, 72716, 72690, 72733] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 4, 2020, 4:20 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72733/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2020, 4:20 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10153 > https://issues.apache.org/jira/browse/MESOS-10153 > > > Repository: mesos > > > Description > ------- > > Implemented the `prepare` method of `volume/csi` isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/state.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/state.proto PRE-CREATION > > > Diff: https://reviews.apache.org/r/72733/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============6227370731370140591==--